Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/8619#discussion_r40389519
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -418,21 +418,21 @@ trait Params extends Identifiable with Serializable {
/**
* Sets a parameter in the embedded param map.
*/
- protected final def set[T](param: Param[T], value: T): this.type = {
--- End diff --
The one that I could think of is if someone was trying to interact with the
object based on which params it had this might be easier, but thats probably
not enough of a reason. I can make this protected and just leave clear public
if that sounds good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
