Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/714#discussion_r14047633
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -236,6 +236,18 @@ class SparkConf(loadDefaults: Boolean) extends
Cloneable with Logging {
}
}
+ // Validate memoryFraction
+ val memoryKeys = Seq(
+ "spark.storage.memoryFraction",
+ "spark.shuffle.memoryFraction",
+ "spark.shuffle.safetyFraction")
+ for (key -> memoryKeys) {
+ val value = getDouble(key, 0.5)
+ if (value > 1 || value < 0) {
+ throw new IllegalArgumentException("$key should be between 0 and
(was '$value').")
--- End diff --
Should say "between 0 and 1" - I can fix this on merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
