Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8910#discussion_r40457129
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtil.scala ---
@@ -314,5 +314,28 @@ object YarnSparkHadoopUtil {
def getClassPathSeparator(): String = {
classPathSeparatorField.get(null).asInstanceOf[String]
}
+
+ /** Get the initial target number of executors depends on dynamic
allocation is enabled or not */
+ def getInitialTargetExecutorNumber(conf: SparkConf): Int = {
+ if (Utils.isDynamicAllocationEnabled(conf)) {
+ val minNumExecutors =
conf.getInt("spark.dynamicAllocation.minExecutors", 0)
+ val initialNumExecutors =
+ conf.getInt("spark.dynamicAllocation.initialExecutors",
minNumExecutors)
+ val maxNumExecutors =
conf.getInt("spark.dynamicAllocation.maxExecutors", Int.MaxValue)
+ require(initialNumExecutors >= minNumExecutors &&
initialNumExecutors <= maxNumExecutors,
+ s"initial executor number $initialNumExecutors must between min
executor number" +
+ s"$minNumExecutors and max executor number $maxNumExecutors")
+
+ initialNumExecutors
+ } else {
+ val targetNumExecutors = if
(System.getenv("SPARK_EXECUTOR_INSTANCES") != null) {
+ IntParam.unapply(System.getenv("SPARK_EXECUTOR_INSTANCES")).get
--- End diff --
`IntParam` just makes this more complicated.
val targetNumExecutors =
sys.env.get("SPARK_EXECUTOR_INSTANCES").map(_.toInt).getOrElse(DEFAULT_NUMBER_EXECUTORS)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
