Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/8889#discussion_r40476942
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -553,60 +553,28 @@ private[hive] class HiveMetastoreCatalog(val client:
ClientInterface, hive: Hive
return plan
}
- // Collects all `MetastoreRelation`s which should be replaced
- val toBeReplaced = plan.collect {
+ plan transformUp {
// Write path
- case InsertIntoTable(relation: MetastoreRelation, _, _, _, _)
- // Inserting into partitioned table is not supported in
Parquet data source (yet).
- if !relation.hiveQlTable.isPartitioned &&
- hive.convertMetastoreParquet &&
-
relation.tableDesc.getSerdeClassName.toLowerCase.contains("parquet") =>
- val parquetRelation = convertToParquetRelation(relation)
- val attributedRewrites =
relation.output.zip(parquetRelation.output)
- (relation, parquetRelation, attributedRewrites)
+ case i @ InsertIntoTable(r: MetastoreRelation, partition, child,
overwrite, ifNotExists)
+ // Inserting into partitioned table is not supported in Parquet
data source (yet).
+ if !r.hiveQlTable.isPartitioned && hive.convertMetastoreParquet
&&
+ r.tableDesc.getSerdeClassName.toLowerCase.contains("parquet")
=>
+ val parquetRelation = convertToParquetRelation(r)
+ InsertIntoTable(parquetRelation, partition, child, overwrite,
ifNotExists)
// Write path
- case InsertIntoHiveTable(relation: MetastoreRelation, _, _, _, _)
+ case i @ InsertIntoHiveTable(r: MetastoreRelation, partition,
child, overwrite, ifNotExists)
// Inserting into partitioned table is not supported in Parquet
data source (yet).
- if !relation.hiveQlTable.isPartitioned &&
- hive.convertMetastoreParquet &&
-
relation.tableDesc.getSerdeClassName.toLowerCase.contains("parquet") =>
- val parquetRelation = convertToParquetRelation(relation)
- val attributedRewrites =
relation.output.zip(parquetRelation.output)
- (relation, parquetRelation, attributedRewrites)
+ if !r.hiveQlTable.isPartitioned && hive.convertMetastoreParquet
&&
+ r.tableDesc.getSerdeClassName.toLowerCase.contains("parquet")
=>
+ val parquetRelation = convertToParquetRelation(r)
+ InsertIntoTable(parquetRelation, partition, child, overwrite,
ifNotExists)
--- End diff --
Or we may preserve `i` and replace this line with `i.copy(table =
parquetRelation)`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
