Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8911#discussion_r40485077
--- Diff:
yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtilSuite.scala
---
@@ -233,4 +234,12 @@ class YarnSparkHadoopUtilSuite extends SparkFunSuite
with Matchers with Logging
}
assert(caught.getMessage === "Can't get Master Kerberos principal for
use as renewer")
}
+
+ test("check different hadoop utils based on env variable") {
+ System.setProperty("SPARK_YARN_MODE", "true")
+ assert(SparkHadoopUtil.get.getClass.getSimpleName ===
"YarnSparkHadoopUtil")
--- End diff --
While we're here, comparing `...getClass === classOf[...]` would be better
IMO. Fewer magic strings.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
