Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r40518453
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -92,13 +93,14 @@ class LinearRegressionSuite extends SparkFunSuite with
MLlibTestSparkContext {
}
test("linear regression with intercept without regularization") {
- val trainer1 = new LinearRegression
- // The result should be the same regardless of standardization without
regularization
- val trainer2 = (new LinearRegression).setStandardization(false)
- val model1 = trainer1.fit(dataset)
- val model2 = trainer2.fit(dataset)
-
- /*
+ Seq("auto", "l-bfgs", "normal").foreach(solver => {
+ val trainer1 = new LinearRegression().setSolver(solver)
+ // The result should be the same regardless of standardization
without regularization
+ val trainer2 = (new
LinearRegression).setStandardization(false).setSolver(solver)
+ val model1 = trainer1.fit(dataset)
+ val model2 = trainer2.fit(dataset)
+
--- End diff --
Update the indentation of the R example.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
