Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1127#discussion_r14051069
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/joins.scala ---
    @@ -245,6 +245,73 @@ case class LeftSemiJoinBNL(
       }
     }
     
    +
    +
    +
    +
    +/**
    + * :: DeveloperApi ::
    + * LeftSemiBloomFilterBroadcastJoin
    + * Sometimes the semijoin's broadcast table can't fit memory.So  we can 
make it as Bloomfilter to  reduce the space
    + * and then broadcast it do the mapside  join
    + * The bloomfilter  use Shark's BloomFilter class implementation.
    + */
    +@DeveloperApi
    +case class LeftSemiJoinBFB(
    +                            leftKeys: Seq[Expression],
    --- End diff --
    
    Indent 4 spaces.  Also I'd go with the full more descriptive name instead 
of BFB since we are only going to have to type it out in like 2 places.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to