Github user olarayej commented on a diff in the pull request:
https://github.com/apache/spark/pull/8908#discussion_r40703484
--- Diff: R/pkg/inst/tests/test_sparkSQL.R ---
@@ -1327,6 +1327,13 @@ test_that("SQL error message is returned from JVM", {
expect_equal(grepl("Table Not Found: blah", retError), TRUE)
})
+test_that("Method as.data.frame as a synonym for collect()", {
+ irisDF <- createDataFrame(sqlContext, iris)
+ expect_equal(as.data.frame(irisDF), collect(irisDF))
+ irisDF2 <- irisDF[irisDF$Species == "setosa", ]
+ expect_equal(as.data.frame(irisDF2), collect(irisDF2))
--- End diff --
I believe this is not necessary, since when I declared
setGeneric("as.data.frame"), I didn't specify any definition. Therefore, my
implementation of as.data.frame would not overwrite R's. I tested it myself,
and as.data.frame() still works for objects other than DataFrame.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
