Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/8867#discussion_r40710630
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/ExecutorDelegationTokenUpdater.scala
---
@@ -76,7 +76,10 @@ private[spark] class ExecutorDelegationTokenUpdater(
SparkHadoopUtil.get.getTimeFromNowToRenewal(
sparkConf, 0.8,
UserGroupInformation.getCurrentUser.getCredentials)
if (timeFromNowToRenewal <= 0) {
- executorUpdaterRunnable.run()
+ // If the `timeFromNowToRenewal` equals 0, it's better to wait 1
minutes to schedule for
+ // avoid cycle calling and cause StackOverflow Exception.
--- End diff --
Oh I see, I assume someone manually changed the renew time for testing
purposes? I think perhaps the comment should be clarified saying if the
renewal time is very small wait 1 minute to avoid calling over and over very
quickly. Or alternatively where we set spark.yarn.token.renewal.interval we
could just do a min of 1 minute.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
