Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8931#discussion_r40723701
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TungstenAggregate.scala
 ---
    @@ -39,7 +40,9 @@ case class TungstenAggregate(
     
       override private[sql] lazy val metrics = Map(
         "numInputRows" -> SQLMetrics.createLongMetric(sparkContext, "number of 
input rows"),
    -    "numOutputRows" -> SQLMetrics.createLongMetric(sparkContext, "number 
of output rows"))
    +    "numOutputRows" -> SQLMetrics.createLongMetric(sparkContext, "number 
of output rows"),
    +    "numBytesUsed" ->
    --- End diff --
    
    this needs to say "memory" somewhere. Also, should it be `peakMemoryUsed` 
to be more accurate?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to