Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/1064#discussion_r14052020
--- Diff: core/src/test/scala/org/apache/spark/ShuffleSuite.scala ---
@@ -56,8 +56,11 @@ class ShuffleSuite extends FunSuite with Matchers with
LocalSparkContext {
}
// If the Kryo serializer is not used correctly, the shuffle would
fail because the
// default Java serializer cannot handle the non serializable class.
- val c = new ShuffledRDD[Int, NonJavaSerializableClass, (Int,
NonJavaSerializableClass)](
- b, new HashPartitioner(NUM_BLOCKS)).setSerializer(new
KryoSerializer(conf))
+ val c = new ShuffledRDD[Int,
+ NonJavaSerializableClass,
+ NonJavaSerializableClass,
+ (Int, NonJavaSerializableClass)](b, new HashPartitioner(NUM_BLOCKS))
--- End diff --
Probably should split out the call to setSerializer into a new statement
instead of chaining it. (Just do `c.setSerializer(...)`.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
