Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8966#discussion_r41057272
  
    --- Diff: 
streaming/src/main/scala/org/apache/spark/streaming/DStreamGraph.scala ---
    @@ -79,7 +79,7 @@ final private[streaming] class DStreamGraph extends 
Serializable with Logging {
       def remember(duration: Duration) {
         this.synchronized {
           if (rememberDuration != null) {
    -        throw new Exception("Remember duration already set as " + 
batchDuration +
    +        throw new Exception("Remember duration already set as " + 
rememberDuration +
    --- End diff --
    
    Sounds good. While you're here though, can you make this use string 
interpolation, and use `require` (so as to avoid generic `Exception`)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to