Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1173#discussion_r14052689
  
    --- Diff: core/src/test/scala/org/apache/spark/util/FileAppenderSuite.scala 
---
    @@ -18,15 +18,18 @@
     package org.apache.spark.util
     
     import java.io._
    +import java.nio.charset.Charset
     
     import scala.collection.mutable.HashSet
     import scala.reflect._
     
    -import org.apache.commons.io.{FileUtils, IOUtils}
    -import org.apache.spark.{Logging, SparkConf}
     import org.scalatest.{BeforeAndAfter, FunSuite}
    +
    +import org.apache.spark.{Logging, SparkConf}
     import org.apache.spark.util.logging.{RollingFileAppender, 
SizeBasedRollingPolicy, TimeBasedRollingPolicy, FileAppender}
     
    +import com.google.common.io.Files
    --- End diff --
    
    nit: mind moving this to before org.apache.spark?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to