Github user alope107 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8318#discussion_r41213092
--- Diff: python/pyspark/pyspark_version.py ---
@@ -0,0 +1,17 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+__version__ = '1.5.0'
--- End diff --
So we remove the version checks entirely in the bundled version, and
include them for the package uploaded to PyPI? I agree that this reduces the
chance for maintainer error, but I'm worried about users upgrading versions of
Spark. A user could install a bundled version of pyspark, and then later point
their SPARK_HOME at a newer version of Spark. There would then be a version
mismatch that wouldn't be detected.
Maybe a middle ground could be to include the version checks in both
bundled and pip installations, but to include a check during PyPI package
generation that the version has been properly set.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
