Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r41420084
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
---
@@ -51,22 +51,42 @@ class SimpleFunctionRegistry extends FunctionRegistry {
private val functionBuilders =
StringKeyHashMap[(ExpressionInfo, FunctionBuilder)](caseSensitive =
false)
- override def registerFunction(name: String, info: ExpressionInfo,
builder: FunctionBuilder)
- : Unit = {
- functionBuilders.put(name, (info, builder))
+ override def registerFunction(
+ name: String,
+ info: ExpressionInfo,
+ builder: FunctionBuilder): Unit = {
+ synchronized {
--- End diff --
Style nit: in most places we put `synchronized` inline with the return type.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
