Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8909#discussion_r41424399
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
    @@ -64,18 +63,28 @@ import org.apache.spark.util.Utils
      *
      * @since 1.0.0
      */
    -class SQLContext(@transient val sparkContext: SparkContext)
    -  extends org.apache.spark.Logging
    -  with Serializable {
    +class SQLContext private[sql](
    +    @transient val sparkContext: SparkContext,
    +    @transient protected[sql] val cacheManager: CacheManager)
    +  extends org.apache.spark.Logging with Serializable {
     
       self =>
     
    +  def this(sparkContext: SparkContext) = this(sparkContext, new 
CacheManager)
    --- End diff --
    
    Let's add scaladoc to explain when it is recommended to use this 
constructor and when it recommended to use `newSession`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to