Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/1173#discussion_r14062333
--- Diff:
core/src/main/scala/org/apache/spark/util/logging/RollingFileAppender.scala ---
@@ -83,7 +83,7 @@ private[spark] class RollingFileAppender(
logDebug(s"Attempting to rollover file $activeFile to file
$rolloverFile")
if (activeFile.exists) {
if (!rolloverFile.exists) {
- FileUtils.moveFile(activeFile, rolloverFile)
+ Files.move(activeFile, rolloverFile)
--- End diff --
why not using `java.nio.file.Files.move(Path source, Path target,
CopyOption... options)`? Does `com.google.common.io.Files` have better
performance than the built-in `Files` in jdk?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
