Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/8988#discussion_r41547271
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetIOSuite.scala
---
@@ -99,16 +99,18 @@ class ParquetIOSuite extends QueryTest with ParquetTest
with SharedSQLContext {
withSQLConf(SQLConf.PARQUET_BINARY_AS_STRING.key ->
"true")(checkParquetFile(data))
}
- test("fixed-length decimals") {
- def makeDecimalRDD(decimal: DecimalType): DataFrame =
- sparkContext
- .parallelize(0 to 1000)
- .map(i => Tuple1(i / 100.0))
- .toDF()
- // Parquet doesn't allow column names with spaces, have to add an
alias here
- .select($"_1" cast decimal as "dec")
+ testStandardAndLegacyModes("fixed-length decimals") {
+ def makeDecimalRDD(decimal: DecimalType): DataFrame = {
+ sqlContext
+ .range(1000)
+ // Parquet doesn't allow column names with spaces, have to add an
alias here.
+ // Minus 500 here so that negative decimals are also tested.
+ .select((('id - 500) / 100.0) cast decimal as 'dec)
--- End diff --
The default decimal type will be (10, 0), should we use a larger scale (or
the numbers will be rounded)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
