Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9000#discussion_r41563670
  
    --- Diff: 
core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala ---
    @@ -1040,17 +1044,23 @@ class BlockManagerSuite extends SparkFunSuite with 
Matchers with BeforeAndAfterE
       test("reserve/release unroll memory") {
         store = makeBlockManager(12000)
         val memoryStore = store.memoryStore
    +    val dummyBlock = TestBlockId("")
    --- End diff --
    
    Since these variables are only used within `reserveUnrollMemoryForThisTask` 
you could define them inside of that method.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to