Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9015#discussion_r41574147
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/utils.scala ---
@@ -204,10 +144,13 @@ object Utils {
}
def planAggregateWithOneDistinct(
- groupingExpressions: Seq[Expression],
+ // The grouping expressions are original groupingExpressions and
+ // distinct columns. For example, for avg(distinct value) ... group
by key
+ // the grouping expressions of this Aggregate Operator will be [key,
value].
+ groupingExpressions: Seq[NamedExpression],
--- End diff --
I will move this comment to the right place while I merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
