Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9019#discussion_r41583866
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects.scala
 ---
    @@ -0,0 +1,334 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.catalyst.expressions
    +
    +import scala.language.existentials
    +
    +import org.apache.spark.sql.catalyst.InternalRow
    +import 
org.apache.spark.sql.catalyst.expressions.codegen.{GeneratedExpressionCode, 
CodeGenContext}
    +import org.apache.spark.sql.types._
    +
    +/**
    + * Invokes a static function, returning the result.  By default, any of 
the arguments being null
    + * will result in returning null instead of calling the function.
    + *
    + * @param staticObject The target of the static call.  This can either be 
the object itself
    + *                     (methods defined on scala objects), or the class 
object
    + *                     (static methods defined in java).
    + * @param dataType The expected return type of the function call
    + * @param functionName The name of the method to call.
    + * @param arguments An optional list of expressions to pass as arguments 
to the function.
    + * @param propagateNull When true, and any of the arguments is null, null 
will be returned instead
    + *                      of calling the function.
    + */
    +case class StaticInvoke(
    +    staticObject: Any,
    +    dataType: DataType,
    +    functionName: String,
    +    arguments: Seq[Expression] = Nil,
    +    propagateNull: Boolean = true) extends Expression {
    +
    +  val objectName = staticObject match {
    +    case c: Class[_] => c.getName
    +    case other => other.getClass.getName.stripSuffix("$")
    +  }
    +  override def nullable: Boolean = true
    +  override def children: Seq[Expression] = Nil
    +
    +  override def eval(input: InternalRow): Any =
    +    throw new UnsupportedOperationException("Only code-generated 
evaluation is supported.")
    +
    +  override def genCode(ctx: CodeGenContext, ev: GeneratedExpressionCode): 
String = {
    +    val javaType = ctx.javaType(dataType)
    +    val argGen = arguments.map(_.gen(ctx))
    +    val argString = argGen.map(_.value).mkString(", ")
    +
    +    if (propagateNull) {
    +      val objNullCheck = if (ctx.defaultValue(dataType) == "null") {
    +        s"${ev.isNull} = ${ev.value} == null;"
    +      } else {
    +        ""
    +      }
    +
    +      val argsNonNull = s"!(${argGen.map(_.isNull).mkString(" || ")})"
    +      s"""
    +        ${argGen.map(_.code).mkString("\n")}
    +
    +        boolean ${ev.isNull} = true;
    +        $javaType ${ev.value} = ${ctx.defaultValue(dataType)};
    +
    +        if ($argsNonNull) {
    +          ${ev.value} = $objectName.$functionName($argString);
    +          $objNullCheck
    +        }
    +       """
    +    } else {
    +      s"""
    +        ${argGen.map(_.code).mkString("\n")}
    +
    +        final boolean ${ev.isNull} = ${ev.value} == null;
    --- End diff --
    
    and the null check should consider primitive type too?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to