Github user steveloughran commented on the pull request:
https://github.com/apache/spark/pull/5423#issuecomment-146959330
Jerry, the code is where it is to isolate it across versions; it started
off where it was in the branch 1.2 era, where the split was common, alpha and
stable
Having another pom would be the maven way, it would avoid the tweaks needed
to expand the source and test files (and one not pushed up to include the dirs
in checkstyle -which was why style issues weren't being picked up by it).
with `yarn/src/history/`, there's the complexity of production and test
sources, so things in the source tree would still be messy, you'd have with
```
yarn/src/history/main/scala
yarn/src/history/test/scala
yarn/src/history/test/resources
```
so...it's still all source, we'd just have a whole extra tree in there. Not
significantly cleaner and we'd still need to have some bits in the POM to deal
with it.
There's one other variant, which is have it in as `yarn/src/hadoop-2.6/...`
. That is no different from `yarn/src/history/`, except that if there is any
more hadoop 2.6-specific YARN code (after all, it's only that dependency that
is keeping it out the main tree), then it could go in the same place. There are
bits in Hadoop 2.6 that haven't been picked up on yet -this would be the place
to add that stuff in isolation.
If people think that's the best name, how about I isolate that change into
a separate patch, one with the pom changes and the diffs to the existing
yarn/src which adds the new yarn extension service trait âsomething @vanzin
suggested I do anyway? Then that can go in as a first step for this bigger
patch?
(Whatever happens, I can see I'll be enjoying handling big changes across
parallel branches. But it's good to get the layout right before its out in the
wild)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
