Github user sun-rui commented on the pull request:
https://github.com/apache/spark/pull/9012#issuecomment-147042037
Personally, I think it is better to support merge() with R signature than
support merge() with scala DataFrame signature (where only name is familiar to
R users but not its signature). So my proposal is:
Remove current merge() definition and implementation;
Note there is no need to define merge() , as merge() is an existing S3
generic function defined in the R base package;
Implement merge() as an S3 method in a new separate R file, maybe
RDataFrame.R (can anyone propose a better name). DataFrame.R is expected to
contain R wrappers for Scala DataFrame functions, while the new R file is
expected to contain R functions with R signature operating on DataFrame.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
