Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9070#discussion_r41731681
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/dstream/TransformedDStream.scala
---
@@ -39,7 +39,10 @@ class TransformedDStream[U: ClassTag] (
override def slideDuration: Duration = parents.head.slideDuration
override def compute(validTime: Time): Option[RDD[U]] = {
- val parentRDDs = parents.map(_.getOrCompute(validTime).orNull).toSeq
+ val parentRDDs = parents.map { parent =>
parent.getOrCompute(validTime).getOrElse(
--- End diff --
You've probably thought through this, so I'm mostly asking: do we want to
assume the parent can be computed? in some places `null` or `None` does
correctly mean "can't be computed now". That may not be here. I'm making sure
we don't 'fix' the wrong part.
PS you can still retain the compact `_.getOrCompute` syntax here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
