Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9072#discussion_r41734082
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
    @@ -1521,8 +1521,15 @@ abstract class RDD[T: ClassTag](
         }
     
         checkpointData match {
    -      case Some(reliable: ReliableRDDCheckpointData[_]) => logWarning(
    -        "RDD was already marked for reliable checkpointing: overriding 
with local checkpoint.")
    +      case Some(reliable: ReliableRDDCheckpointData[_]) =>
    --- End diff --
    
    I suspect this is a good restriction, but cc @tdas regarding the semantics.
    
    I feel like this code construct is getting hard to read. I don't feel 
strongly, but is `if (checkpointData.isDefined && isCheckpointed)` not simpler? 
then there are just two branches, one return point.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to