Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9059#discussion_r41768301
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala ---
@@ -289,13 +290,14 @@ private[ui] class AllJobsPage(parent: JobsTab)
extends WebUIPage("") {
val summary: NodeSeq =
<div>
<ul class="unstyled">
- {if (parent.sc.isDefined) {
- // Total duration is not meaningful unless the UI is live
- <li>
- <strong>Total Uptime: </strong>
- {UIUtils.formatDuration(System.currentTimeMillis() -
startTime)}
- </li>
+ <li>
+ <strong>Total Uptime: </strong>
+ {if (parent.sc.isDefined) {
--- End diff --
This seems OK, but can it be even simpler?
`{UIUtils.formatDuration((if (parent.sc.isDefined)
System.currentTimeMillis() else endTime) - startTime)}`
Or maybe pull out a `val` to simplify.
In any event LGTM in principle
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
