Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8976#discussion_r41827562
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -147,10 +139,9 @@ class SparkContext(config: SparkConf) extends Logging
with ExecutorAllocationCli
* @param jars Collection of JARs to send to the cluster. These can be
paths on the local file
* system or HDFS, HTTP, HTTPS, or FTP URLs.
* @param environment Environment variables to set on worker nodes.
- * @param preferredNodeLocationData used in YARN mode to select nodes to
launch containers on.
- * Can be generated using
[[org.apache.spark.scheduler.InputFormatInfo.computePreferredLocations]]
- * from a list of input files or InputFormats for the application.
+ * @param preferredNodeLocationData not used. Left for backward
compatibility.
*/
+ @deprecated("Passing in preferred locations has no effect at all, see
SPARK-10921", "1.6.0")
--- End diff --
I was going to say, hm, it may be funny to deprecate and then un-deprecate
this if `preferredNodeLocationData` comes back. But then again, another
constructor with this parameter was already deprecated. But then that one was a
`@DeveloperApi`. All in all I think this change is OK though, on grounds of
consistency. Un-deprecating isn't a big deal.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
