Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9096#discussion_r41845779
--- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskLocation.scala
---
@@ -62,12 +62,5 @@ private[spark] object TaskLocation {
* These strings have the form [hostname] or hdfs_cache_[hostname],
depending on whether the
* location is cached.
*/
- def apply(str: String): TaskLocation = {
- val hstr = str.stripPrefix(inMemoryLocationTag)
- if (hstr.equals(str)) {
- new HostTaskLocation(str)
- } else {
- new HostTaskLocation(hstr)
- }
- }
+ def apply(str: String): TaskLocation = new
HostTaskLocation(str.stripPrefix(inMemoryLocationTag))
--- End diff --
Seems OK, but this seems too minor to bother with the overhead of reviewing
and testing. Maybe you can consider changes like this as part of larger logical
changes in the future?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
