Github user concretevitamin commented on the pull request:

    https://github.com/apache/spark/pull/1163#issuecomment-47029361
  
    I have updated this PR to only include broadcast hash join, as well as its 
test.
    
    For the join test framework: if we want to add this, we can do it in a 
follow-up PR in the future. Currently I just put all join-related tests into 
one place. For the specific case of BHJ, the existing testing infrastructure 
seems adequate enough for testing the planner as well as the correctness of 
output.
    
    For size estimation: I have removed all related changes in this PR. We'd 
want to think more about this and come up with a more general framework for 
support estimation. Therefore, the only way to use BHJ with this patch is to 
provide a hint.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to