GitHub user kayousterhout opened a pull request:
https://github.com/apache/spark/pull/1198
Fix broken Json tests.
The assertJsonStringEquals method was missing an "assert" so
did not actually check that the strings were equal. This commit
adds the missing assert and fixes subsequently revealed problems
with the JsonProtocolSuite.
@andrewor14 I changed some of the test functionality to match what it
looks like you intended based on the expected strings -- let me know if
anything here looks wrong.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kayousterhout/spark-1 json_test_fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/1198.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1198
----
commit 77f858ff18f975de872634f2788abf3a4016ed5f
Author: Kay Ousterhout <[email protected]>
Date: 2014-06-24T20:58:13Z
Fix broken Json tests.
The assertJsonStringEquals method was missing an "assert" so
did not actually check that the strings were equal. This commit
adds the missing assert and fixes subsequently revealed problems
with the JsonProtocolSuite.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
