Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7417#discussion_r41954063
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -274,12 +275,30 @@ private[sql] abstract class SparkStrategies extends
QueryPlanner[SparkPlan] {
}
object CartesianProduct extends Strategy {
+ def getSmallSide(left: LogicalPlan, right: LogicalPlan): BuildSide = {
+ if (right.statistics.sizeInBytes < left.statistics.sizeInBytes) {
+ joins.BuildRight
+ } else {
+ joins.BuildLeft
+ }
+ }
--- End diff --
I am not sure comparing the total size will give us a very useful
heuristics because the size of a table does not imply anything about the size
of a partition. Also, I am inclined to get
https://github.com/apache/spark/pull/8652/files merged first and then add any
other optimization in a follow-up PR. What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
