Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9112#discussion_r41961012
--- Diff: core/src/main/scala/org/apache/spark/rpc/netty/NettyRpcEnv.scala
---
@@ -406,49 +409,37 @@ private[netty] class NettyRpcHandler(
private type RemoteEnvAddress = RpcAddress
// Store all client addresses and their NettyRpcEnv addresses.
+ // TODO: Is this even necessary?
@GuardedBy("this")
private val remoteAddresses = new mutable.HashMap[ClientAddress,
RemoteEnvAddress]()
--- End diff --
@zsxwing is this necessary at all? Maybe it is ok to not have this and
always reconstruct the RpcAddress.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
