Github user vundela commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9118#discussion_r42043730
  
    --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
    @@ -340,6 +340,14 @@ private[spark] class Client(
               "for alternatives.")
         }
     
    +    // Uploading $SPARK_CONF_DIR/log4j.properties file to the distributed 
cache to make sure that
    +    // the executor's will use the latest configurations instead of the 
default values. This is
    +    // required when user changes log4j.properties directly or use's UI 
(e.g., Cloudera Manager) to
    +    // set the log configurations. If configuration file is provided 
through --files then executors
    +    // will be taking configurations from --files instead of 
$SPARK_CONF_DIR/log4j.properties.
    +    val log4jConf =
    +      
oldLog4jConf.orElse(Option(getClass.getResource("/log4j.properties").toString()))
    --- End diff --
    
    It might, if the resource not found. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to