Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9038#discussion_r42058972
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TungstenAggregationIterator.scala
---
@@ -481,10 +610,10 @@ class TungstenAggregationIterator(
// When needsProcess is false, the format of input rows is
groupingKey + aggregation buffer.
// We need to project the aggregation buffer part from an input row.
val buffer = createNewAggregationBuffer()
- // The originalInputAttributes are using cloneBufferAttributes. So,
we need to use
- // allAggregateFunctions.flatMap(_.cloneBufferAttributes).
+ // The originalInputAttributes are using inputAggBufferAttributes.
So, we need to use
+ // allAggregateFunctions.flatMap(_.inputAggBufferAttributes).
val bufferExtractor = newMutableProjection(
- allAggregateFunctions.flatMap(_.inputAggBufferAttributes),
+ originalInputAttributes.drop(initialInputBufferOffset),
--- End diff --
I'm folding this into the comments right now. Thanks for summarizing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
