Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/9123#discussion_r42091740
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -482,7 +482,12 @@ class Analyzer(
val newOrdering = resolveSortOrders(ordering, grandchild, throws =
true)
// Construct a set that contains all of the attributes that we need
to evaluate the
// ordering.
- val requiredAttributes = AttributeSet(newOrdering.filter(_.resolved))
+
+ val resolvedAttributes =
+ newOrdering.flatMap(_.collect {case a : AttributeReference if
a.resolved => a})
+
+ val requiredAttributes = AttributeSet(resolvedAttributes)
--- End diff --
how about
`val requiredAttributes = AttributeSet(newOrdering).filter(_.resolved)`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
