Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-148321601
I'll be able to merge this PR once the following two issues are addressed,
1) Have a test to verify that `L1` with normal will throw
`IllegalArugmentExcpetion`. I prefer have the test inside `Seq("auto",
"l-bfgs") since I'll work on solving L1 with `normal` later, so what we need to
do it just remove the `Intercept`. Also, we can precise know what part is not
supported if we have the tests together.
2) Currently, we allow weighted LiR in `normal` mode, but we don't have a
test verifying they get the same solution. Please add a test for this. If they
are in fact returning different solution, then throw exception saying that
weighted LiR doesn't support `normal` mode, and in `auto` mode with weighted
LiR, we should do `l-bfgs`. Then we address the inconsistent issue in a
separated PR.
Thanks. Once those two issues are solved, I'll merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
