Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8887#discussion_r42266241
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/ExecutorLossReason.scala ---
    @@ -37,6 +37,8 @@ private[spark] object ExecutorExited {
       }
     }
     
    +private [spark] object LossReasonPending extends 
ExecutorLossReason("Pending loss reason.")
    --- End diff --
    
    As I explained in previous comments, I don't like this approach to the 
problem (the previous version doesn't use this class, instead there's an 
explicit `disableExecutor()` method in the scheduler). I'll wait for Kay to 
take a look before applying any feedback, in case she's ok with me just 
reverting my last commit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to