Github user NarineK commented on the pull request:
https://github.com/apache/spark/pull/9012#issuecomment-148787306
Hi @felixcheung,
thanks for your comments.
1. I'm a bit confused - why create a seq of indices? instead can't we use
lapply on allColNames?
yes, that's true. I could have used smth like:
lapply(allColNames, function(colNames)){
colName ...
...
})
Thnx!
Also, nit, why pass allColNames if we could just do names(x) here?
yes, I can do names(x) and names(y) in the method.
2. what if colName is "test", suffix is "_x" but there is already a column
with the name "test_x"?
I think that's not good. I could check if the alias names already exist in
the dataframe.
If they do, I can show an error telling the user to use a different suffix.
--------------------------------------------------------------------------------------------------------------------------------
3. does the suffix to be used here depends on the type of join?
No, the suffix doesn't depend on join type
------------------------------------------------------------------------------------------------------------------------------
4. please add a test sort = T
yes, I'll add that
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
