Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9122#discussion_r42277272
  
    --- Diff: python/pyspark/context.py ---
    @@ -280,6 +280,18 @@ def __exit__(self, type, value, trace):
             """
             self.stop()
     
    +    @classmethod
    +    def getOrCreate(cls, conf=None):
    +        """
    +        Get or instantiate a SparkContext and register it as a singleton 
object.
    +
    +        :param conf: SparkConf (optional)
    +        """
    +        if SparkContext._active_spark_context is None:
    --- End diff --
    
    don't you need to hold `SparkContext._lock` when you check for this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to