Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9145#discussion_r42278194
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/columnar/InMemoryColumnarTableScan.scala
---
@@ -43,7 +42,7 @@ private[sql] object InMemoryRelation {
tableName)()
}
-private[sql] case class CachedBatch(buffers: Array[Array[Byte]], stats:
InternalRow)
+private[sql] case class CachedBatch(count: Int, buffers:
Array[Array[Byte]], stats: InternalRow)
--- End diff --
let's add classdoc for count, buffers, and stats.
Without looking at the code it is less clear what count is here. (Is it the
total number of rows?)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
