Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/7910#issuecomment-148820708
I just tested this out and noticed a few problems:
- The full-text search doesn't seem to properly search all columns; I tried
some queries and found that it returned fewer rows than expected.
- The hover styling on the tables causes the width to jump around when the
text becomes bold. I'd prefer to only highlight the background of the table
cells.
- It would be nice if the cursor changed to indicate that table cells are
clickable; this should be fixable with CSS.
- The new layout makes the thread dumps harder to read. Rather than adding
an additional column when a thread-dump is displayed, I think it would make
more sense to expand the table row so that the thread dump appears underneath
the table columns in that row. This isn't trivial to implement, but I still
think we should do it.
Given all of this, I don't think that this PR is ready to merge in its
current form. @CodingCat, if you don't anticipate having time to make these
changes, would you mind closing this in the meantime to help de-clutter the PR
review queue? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
