Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/8757#issuecomment-148851400
This LGTM. I'll merge it with master. Thanks for the PR!
@avulanov I looked at your code, but the results seem strange to me. We'll
have to look into it more, I guess. As far as utility of block-diagonal
matrices, I've mainly seen them in the context of specialized applications with
very structured feature interactions, but my experience there is from research,
not industry.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
