Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/9138#discussion_r42303460
--- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala
---
@@ -387,6 +362,31 @@ private[deploy] class Master(
}
override def receiveAndReply(context: RpcCallContext):
PartialFunction[Any, Unit] = {
+ case RegisterWorker(
+ id, workerHost, workerPort, workerRef, cores, memory,
workerUiPort, publicAddress) => {
+ logInfo("Registering worker %s:%d with %d cores, %s RAM".format(
+ workerHost, workerPort, cores, Utils.megabytesToString(memory)))
+ if (state == RecoveryState.STANDBY) {
+ // ignore, don't send response
--- End diff --
what I'm saying is in general in `receiveAndReply` you should always reply
because that's what the caller expects. Otherwise it's really confusing when we
get future timeouts cause they're hard to debug.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
