Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8669#discussion_r42311622
--- Diff: bin/load-spark-env.sh ---
@@ -20,7 +20,29 @@
# This script loads spark-env.sh if it exists, and ensures it is only
loaded once.
# spark-env.sh is loaded from SPARK_CONF_DIR if set, or within the current
directory's
# conf/ subdirectory.
-FWDIR="$(cd "`dirname "$0"`"/..; pwd)"
+realpath () {
--- End diff --
Can this function be replaced by:
DIR="$(dirname "$(readlink -f "$0")")"
I see you're recursively resolving the symlink and putting a limit in the
depth of recursion, but it sounds like `readlink -f` does just that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]