Github user ryan-williams commented on a diff in the pull request:
https://github.com/apache/spark/pull/9147#discussion_r42387794
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala ---
@@ -430,17 +430,20 @@ private[yarn] class YarnAllocator(
for (completedContainer <- completedContainers) {
val containerId = completedContainer.getContainerId
val alreadyReleased = releasedContainers.remove(containerId)
+ val hostOpt = allocatedContainerToHostMap.get(containerId)
+ val onHostStr = hostOpt.map(host => s" on host: $host").getOrElse("")
val exitReason = if (!alreadyReleased) {
// Decrement the number of executors running. The next iteration of
// the ApplicationMaster's reporting thread will take care of
allocating.
numExecutorsRunning -= 1
- logInfo("Completed container %s (state: %s, exit status:
%s)".format(
+ logInfo("Completed container %s%s (state: %s, exit status:
%s)".format(
--- End diff --
Yea I originally did some more aggressive converting to
interpolated-strings here because that seems like a better way to do things in
general, but such strings often make for absurdly long lines, and I don't have
a solution I like to that (e.g. breaking onto multiple lines with `+`s seems
gross), so I think I reverted that here and went for the more minimal change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
