Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-149365106
@sethah Besides inline comments, we can also think about how to simplify
the class inheritance. It would be better if we don't need to touch
`InternalRow` in subclasses. Also, `Variance` is the same as `VarianceSamp`,
shall we make one inherit another with a different `prettyName`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]