Github user tgravescs commented on the pull request:

    https://github.com/apache/spark/pull/900#issuecomment-47104091
  
    thanks @li-zhihui. I was actually referring to modifying the user docs to 
add the new configs.  look in docs/configuration.md.   
    
    It makes sense to move it down and get as much initialization stuff out of 
the way before waiting.  To me exactly which class it goes in depends on how we 
see it fitting and potentially being used in the future.  You could for 
instance move it down into submitMissingTasks before the call to submitTasks 
and leave it in DAGScheduler instead.
    
    I think for this pr where we are just checking initially (job submission) 
that we have enough executors it doesn't matter to much.  But in the future if 
we would want to check between stages or potentially when adding tasks then it 
matters where it goes.  
    
    perhaps @kayousterhout has opinion on where it better fits?   



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to