Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1203#discussion_r14201947
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/worker/Worker.scala 
---
    @@ -333,18 +327,20 @@ private[spark] class Worker(
           finishedDrivers(driverId) = driver
           memoryUsed -= driver.driverDesc.mem
           coresUsed -= driver.driverDesc.cores
    -    }
     
    -    case x: DisassociatedEvent if x.remoteAddress == masterAddress =>
    -      logInfo(s"$x Disassociated !")
    -      masterDisconnected()
    +    case d @ DisassociatedEvent(localAddress, remoteAddress, inbound) =>
    +      if (remoteAddress == masterAddress) {
    +        logInfo(s"$d Disassociated!")
    +        masterDisconnected()
    +      } else {
    +        logWarning(s"Received unknown dissociation event: $d")
    --- End diff --
    
    I don't think this warning is a good idea. The worker also can become 
disassociated from the executor or driver actors, in those cases I'm not sure 
we want to log a warning.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to