Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/8314#discussion_r42514590
--- Diff:
core/src/test/scala/org/apache/spark/rdd/PairRDDFunctionsSuite.scala ---
@@ -588,7 +588,7 @@ class PairRDDFunctionsSuite extends SparkFunSuite with
SharedSparkContext {
}
val stdev = if (withReplacement) math.sqrt(expected) else
math.sqrt(expected * p * (1 - p))
// Very forgiving margin since we're dealing with very small sample
sizes most of the time
- math.abs(actual - expected) <= 6 * stdev
+ math.abs(actual - expected) <= 6 * stdev + 2
--- End diff --
I thought this was a better way to leave a bigger margin for the low count
cases, rather than increasing the multiplier. As another random point, `4 *
stdev + 4` also worked.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
