Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/9145#discussion_r42564979
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/columnar/ColumnType.scala ---
@@ -219,11 +251,11 @@ private[sql] object DOUBLE extends
NativeColumnType(DoubleType, 8) {
}
override def extract(buffer: ByteBuffer): Double = {
- buffer.getDouble()
+ ByteBufferHelper.getDouble(buffer)
}
override def extract(buffer: ByteBuffer, row: MutableRow, ordinal: Int):
Unit = {
- row.setDouble(ordinal, buffer.getDouble())
+ row.setDouble(ordinal, ByteBufferHelper.getDouble(buffer))
}
override def setField(row: MutableRow, ordinal: Int, value: Double):
Unit = {
--- End diff --
Around line 332, there is call to buffer.getShort()
Is it worth adding corresponding method to ByteBufferHelper ?
If so, I can send a PR.
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
